Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show track view if there is only one track #1209

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Don't show track view if there is only one track #1209

wants to merge 4 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Nov 7, 2023

If an event has only a single track, you cannot deselect that track, so the track view is rather pointless in that case. Therefore, we might as well not show it.

Fixes #1205.

@Arnei
Don't show track view if there is only one track
67b69a7 
If an event has only a single track, you cannot deselect that track,
so the track view is rather pointless in that case. Therefore, we might
as well not show it.
@Arnei Arnei added the type:visual-clarity A part of the UI is not visually readable label Nov 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

This pull request is deployed at test.editor.opencast.org/1209/2023-11-07_09-24-17/ .
It might take a few minutes for it to become available.

LukasKalbertodt
LukasKalbertodt approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and seems to work (see https://test.editor.opencast.org/1209/2023-11-07_09-24-17/?mediaPackageId=ID-nasa-earth-4k)

@lkiesow
Copy link
Member

lkiesow commented Nov 14, 2023

It might still be confusing to users when part of the tooling just silently disappears.
Maybe just adding an info box to the track selection would actually be better?
There you could put that this tool is disabled and why.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Jan 18, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Jan 18, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1209/2024-01-18_15-16-40/ .
It might take a few minutes for it to become available.

KatrinIhler
KatrinIhler requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@KatrinIhler KatrinIhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here only the info box thingy is still outstanding. Requesting changes to accurately represent the state.

@Arnei
Show info box instead of unactionable track selection
58553e6 
Reverts previous change of not showing the
track selection at all, and instead shows
an info box in the track selection view.
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label May 13, 2024
@Arnei
Copy link
Member Author

Arnei commented May 13, 2024 •
edited
Loading

Basic info box, I hope that is what people expected. Suggestions for phrasing are welcome :)

Bildschirmfoto vom 2024-05-13 15-45-26

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label May 14, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1209/2024-05-14_06-11-34/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatrinIhler KatrinIhler KatrinIhler requested changes

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip the "Tracks" section of the editor if there is only one track
4 participants
@Arnei @lkiesow @LukasKalbertodt @KatrinIhler